Re: [PATCH v2 0/3] completion: bash: support for recursive/nested aliases

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 10, 2020, 01:47 UTC
Message-ID: <xmqqv9ee7zkx.fsf@gitster.c.googlers.com>
In-Reply-To: <20201110005331.532678-1-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 15 quoted lines

> Hello,
>
> As Philippe reported, aliases of aliases are not completed correctly in the
> Bash completion. This patch series attempts to fix that problem.
>
> Since v1:
>
>  * Use a loop instead of recursive calls
>  * Add a check to detect alias loops
>
>
> Felipe Contreras (3):
>   completion: bash: support recursive aliases
>   completion: bash: check for alias loop
>   completion: bash: simplify __git_aliased_command

It is unclear why 3/3 needs to be separate (in other words, is there a reason why 1/3 and 2/3 need to be done while the function is in the more complex form, instead of doing what 1/3 and 2/3 wanted to do to the function in a way that does not require later clean-up?), but other than that, the end-result looks good.

Will queue.