[PATCH v2 2/3] completion: bash: check for alias loop
We don't want to be stuck in an endless cycle.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
contrib/completion/git-completion.bash | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 59ced25641..bf2a59f95e 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1121,11 +1121,17 @@ __git_pretty_aliases ()
# __git_aliased_command requires 1 argument
__git_aliased_command ()
{
- local cur=$1 last word cmdline
+ local cur=$1 last list word cmdline
while [[ "$cur" != "$last" ]]; do
+ if [[ "$list" == *"$cur "* ]]; then
+ # loop detected
+ return
+ fi
+
cmdline=$(__git config --get "alias.$cur")
last=$cur
+ list="$cur $list"
for word in $cmdline; do
case "$word" in
--
2.29.2
Felipe Contreras <felipe.contreras@gmail.com>