git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/3] completion: bash: simplify __git_aliased_command

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Nov 10, 2020, 00:53 UTC
Message-ID
<20201110005331.532678-4-felipe.contreras@gmail.com>
In-Reply-To
<20201110005331.532678-1-felipe.contreras@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index bf2a59f95e..ce0dc1e0f8 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1121,17 +1121,17 @@ __git_pretty_aliases ()
 # __git_aliased_command requires 1 argument
 __git_aliased_command ()
 {
-	local cur=$1 last list word cmdline
+	local cur=$1 list word cmdline
 
-	while [[ "$cur" != "$last" ]]; do
+	while [[ -n "$cur" ]]; do
 		if [[ "$list" == *"$cur "* ]]; then
 			# loop detected
 			return
 		fi
 
 		cmdline=$(__git config --get "alias.$cur")
-		last=$cur
 		list="$cur $list"
+		cur=
 
 		for word in $cmdline; do
 			case "$word" in
@@ -1154,6 +1154,7 @@ __git_aliased_command ()
 		done
 	done
 
+	cur="${list%% *}"
 	if [[ "$cur" != "$1" ]]; then
 		echo "$cur"
 	fi
-- 
2.29.2
Previous: Felipe ContrerasNext: Junio C Hamano
Message 4 of 6 in “completion: bash: support for recursive/nested aliases”
  1. 0/3 completion: bash: support for recursive/nested aliasesFelipe Contreras, Nov 10, 2020
  2. 1/3 completion: bash: support recursive aliasesFelipe Contreras, Nov 10, 2020
  3. 2/3 completion: bash: check for alias loopFelipe Contreras, Nov 10, 2020
  4. 3/3 completion: bash: simplify __git_aliased_commandFelipe Contreras, Nov 10, 2020
  5. Junio C HamanoNov 10, 2020
  6. Felipe ContrerasNov 10, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.