git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] t/lib-read-tree-m-3way: replace spaces with tabs

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 1, 2022, 23:57 UTC
Message-ID
<xmqqv8xy87io.fsf@gitster.g>
In-Reply-To
<20220130094357.515335-3-shaoxuan.yuan02@gmail.com>
Shaoxuan Yuan <shaoxuan.yuan02@gmail.com> writes:
Show 8 quoted lines
> Signed-off-by: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
> ---
>
> This commit simply replaced indentation spaces with tabs.
> e.g.
>
> -    git update-index --add SS
> +	git update-index --add SS
The same comment applies wrt where the message is placed.

I'd view "replace spaces with" as a way to achieve "indent with tabs".

    t/lib-read-tree-m-3way: indent with tabs
    As Documentation/CodingGuidelines says, our shell scripts
    (including tests) are to use HT for indentation, but this script
    uses 4-column indent with SP.  Fix this.
or something like that, perhaps?
Previous: Shaoxuan YuanNext: Shaoxuan Yuan
Message 9 of 22 in “lib-read-tree-m-3way: modernize a test script (style)”
  1. Shaoxuan YuanJan 23, 2022
  2. Shaoxuan YuanJan 27, 2022
  3. Eric SunshineJan 28, 2022
  4. Shaoxuan YuanJan 28, 2022
  5. Eric SunshineFeb 5, 2022
  6. Shaoxuan YuanFeb 7, 2022
  7. 0/2 t/lib-read-tree-m-3way: modernize a test scriptShaoxuan Yuan, Jan 30, 2022
  8. 2/2 t/lib-read-tree-m-3way: replace spaces with tabsShaoxuan Yuan, Jan 30, 2022
  9. Junio C HamanoFeb 1, 2022
  10. Shaoxuan YuanFeb 2, 2022
  11. 1/2 t/lib-read-tree-m-3way: replace double quotes with single quotesShaoxuan Yuan, Jan 30, 2022
  12. Junio C HamanoFeb 1, 2022
  13. Shaoxuan YuanFeb 2, 2022
  14. 1/2 t/lib-read-tree-m-3way: modernize styleShaoxuan Yuan, Feb 2, 2022
  15. 2/2 t/lib-read-tree-m-3way: indent with tabsShaoxuan Yuan, Feb 2, 2022
  16. Christian CouderFeb 7, 2022
  17. Shaoxuan YuanFeb 8, 2022
  18. Christian CouderFeb 7, 2022
  19. Shaoxuan YuanFeb 8, 2022
  20. 0/2 t/lib-read-tree-m-3way: modernize a test scriptShaoxuan Yuan, Feb 8, 2022
  21. 1/2 t/lib-read-tree-m-3way: modernize styleShaoxuan Yuan, Feb 8, 2022
  22. 2/2 t/lib-read-tree-m-3way: indent with tabsShaoxuan Yuan, Feb 8, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.