Re: [PATCH v2 2/2] t/lib-read-tree-m-3way: replace spaces with tabs
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 1, 2022, 23:57 UTC
- Message-ID
- <xmqqv8xy87io.fsf@gitster.g>
- In-Reply-To
- <20220130094357.515335-3-shaoxuan.yuan02@gmail.com>
Shaoxuan Yuan <shaoxuan.yuan02@gmail.com> writes:
Show 8 quoted lines
> Signed-off-by: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com> > --- > > This commit simply replaced indentation spaces with tabs. > e.g. > > - git update-index --add SS > + git update-index --add SS
The same comment applies wrt where the message is placed.
I'd view "replace spaces with" as a way to achieve "indent with tabs".
t/lib-read-tree-m-3way: indent with tabs
As Documentation/CodingGuidelines says, our shell scripts
(including tests) are to use HT for indentation, but this script
uses 4-column indent with SP. Fix this.or something like that, perhaps?