Re: [PATCH v2 2/2] t/lib-read-tree-m-3way: replace spaces with tabs

From: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
Date: Feb 2, 2022, 04:59 UTC
Message-ID: <CAJyCBORJ=_EO43qfcBkbTdzY74RBeP67zfUqAcJz_WkcfqBmYw@mail.gmail.com>
In-Reply-To: <xmqqv8xy87io.fsf@gitster.g>

On Wed, Feb 2, 2022 at 7:57 AM Junio C Hamano <gitster@pobox.com> wrote:

> I'd view "replace spaces with" as a way to achieve "indent with
> tabs".

Oh my. It looks so noob to say "replace spaces with". And for sure this is a much better way to phrase it. Guess I was having some turbulence writing this patch, I should phrase it like that ;-)

Show 7 quoted lines

>     t/lib-read-tree-m-3way: indent with tabs
>
>     As Documentation/CodingGuidelines says, our shell scripts
>     (including tests) are to use HT for indentation, but this script
>     uses 4-column indent with SP.  Fix this.
>
> or something like that, perhaps?

Learned the present tense and imperative mood :)

-- Thanks, Shaoxuan