From: Junio C Hamano Date: Tue, 01 Feb 2022 23:57:35 GMT Subject: Re: [PATCH v2 2/2] t/lib-read-tree-m-3way: replace spaces with tabs Message-ID: In-Reply-To: <20220130094357.515335-3-shaoxuan.yuan02@gmail.com> Shaoxuan Yuan writes: > Signed-off-by: Shaoxuan Yuan > --- > > This commit simply replaced indentation spaces with tabs. > e.g. > > - git update-index --add SS > + git update-index --add SS The same comment applies wrt where the message is placed. I'd view "replace spaces with" as a way to achieve "indent with tabs". t/lib-read-tree-m-3way: indent with tabs As Documentation/CodingGuidelines says, our shell scripts (including tests) are to use HT for indentation, but this script uses 4-column indent with SP. Fix this. or something like that, perhaps?