git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: fix incorrect --write-junit-xml code

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 8, 2022, 16:47 UTC
Message-ID
<xmqqv8r2smvr.fsf@gitster.g>
In-Reply-To
<s4s2qr56-2948-p025-rrq7-qq56p9oo844r@tzk.qr>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> I still think that we need to slow the heck down with refactoring for
> refactoring's sake because it's not only the CI builds that are affected.
> I pay a lot of time to accommodate for those refactorings, and so do
> others, and the benefit of most of those refactorings escapes me.
Absolutely.
> You asked me in private to provide more reviews for those refactorings so
> that they see some push-back, but I lack the bandwidth for that.

I do remember telling you to push back what you do not want to see in 'seen' and advance to 'next'. If everybody lacks the bandwidth for shooting down bad ideas and only has time to promote their own ideas, which are not guaranteed to be good ones, it does not lead to a good place X-<.

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 5 of 9 in “tests: fix incorrect --write-junit-xml code”
  1. tests: fix incorrect --write-junit-xml codeJohannes Schindelin via GitGitGadget, Jul 14, 2022
  2. Junio C HamanoJul 14, 2022
  3. Ævar Arnfjörð BjarmasonJul 15, 2022
  4. Johannes SchindelinAug 8, 2022
  5. Junio C HamanoAug 8, 2022
  6. Johannes SchindelinAug 9, 2022
  7. Junio C HamanoAug 10, 2022
  8. Johannes SchindelinAug 12, 2022
  9. never refactor v.s. testing (was: [PATCH] tests: fix incorrect --write-junit-xml code)Ævar Arnfjörð Bjarmason, Jul 15, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.