Re: [PATCH] tests: fix incorrect --write-junit-xml code

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 12, 2022, 21:00 UTC
Message-ID: <78npn9qp-2263-sosp-8901-4484s4499q99@tzk.qr>
In-Reply-To: <xmqqpmh8kkfb.fsf@gitster.g>

Hi Junio,

On Wed, 10 Aug 2022, Junio C Hamano wrote:

Show 9 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > The funny thing is that you're usually simply not picking up patches that
> > do not get any reviews, but for these refactorings it is somehow
> > different, and I do not understand why it needs to be different.
>
> Well, I am not sure if encouraging the maintainer to drop patches
> that are not reviewed is a good overall direction you would want to
> go in.

I am not encouraging you to drop high-quality patches that have a clear benefit to the project and/or Git's users. You probably know me better than to assume that I would ever do such a thing. You probably meant this comment tongue-in-cheek, but I cannot really tell.

It's about these long patch series that touch everything and their dog and the end result brings no clear benefit to users nor the Git project itself. I can easily imagine how wonderful it would be not to see such patch series ever again. ;-)

> But let's try that.  Less work for me, less disruption to our tree,
> and the world may be quieter and more pleasant ;-)

Amen!

Ciao, Dscho