Re: [PATCH] tests: fix incorrect --write-junit-xml code

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 9, 2022, 08:42 UTC
Message-ID: <3qn5r283-3232-4s58-8q9s-n67o407nr816@tzk.qr>
In-Reply-To: <xmqqv8r2smvr.fsf@gitster.g>

Hi Junio,

On Mon, 8 Aug 2022, Junio C Hamano wrote:

Show 10 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > You asked me in private to provide more reviews for those refactorings so
> > that they see some push-back, but I lack the bandwidth for that.
>
> I do remember telling you to push back what you do not want to see
> in 'seen' and advance to 'next'.  If everybody lacks the bandwidth
> for shooting down bad ideas and only has time to promote their own
> ideas, which are not guaranteed to be good ones, it does not lead
> to a good place X-<.

The funny thing is that you're usually simply not picking up patches that do not get any reviews, but for these refactorings it is somehow different, and I do not understand why it needs to be different.

I do not _want_ to spend time reviewing patch series of dubious benefit. And that would hold true even if I could justify spending that time, which I can't.

There are so many more contributions that promise a much higher return of investment for reviewing them.

Ciao, Dscho