Re: [PATCH 2/4] sequencer: do not translate parameters to error_resolve_conflict()

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 22, 2022, 16:12 UTC
Message-ID: <xmqqv8qkdzpu.fsf@gitster.g>
In-Reply-To: <oqq42q11-3031-91or-no50-p68q85po1492@tzk.qr>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> ... We want code contribution to have a high quality, and the
> code reviews should meet at least the same bar.

I like that one. Ævar is not alone, but many of us often throw an unrelated "observation" into a review thread that is a total tangent. While I do not think it is necessarily a bad thing, because these tangential discussions often turn into separate idea that lead to improvements, we should learn to (1) mark a tangent clearly as such and (2) keep the quality of the tangent reasonably high.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.