Re: [PATCH 0/2] Generalize reference locking in tests
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 11, 2024, 00:36 UTC
- Message-ID
- <xmqqv8807ll1.fsf@gitster.g>
- In-Reply-To
- <pull.1634.git.1704912750.gitgitgadget@gmail.com>
"Justin Tobler via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 5 quoted lines
> This approach is more verbose and may warrant consideration of implementing > an abstraction to further simplify this operation. There appears to be one > other existing test in t1400 that also follows this pattern. Being that > there is only a handful of affected tests the implemented approach may be > sufficient as is.
The use of two fifos and avoiding deadlocking parent and child is tricky enough that it does feel that it warrants a helper function to do the common part of what these two patches add.
I think I read t1401 patch carefully enough to understand what is going on, but I cannot yet claim the same for the other one.
Thanks.
Show 13 quoted lines
> Justin Tobler (2): > t1401: generalize reference locking > t5541: generalize reference locking > > t/t1401-symbolic-ref.sh | 28 ++++++++++++++++++++++++---- > t/t5541-http-push-smart.sh | 25 +++++++++++++++++++++++-- > 2 files changed, 47 insertions(+), 6 deletions(-) > > > base-commit: 624eb90fa8f65a79396615f3c2842ac5a3743350 > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1634%2Fjltobler%2Fjt%2Fbackend-generic-ref-lock-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1634/jltobler/jt/backend-generic-ref-lock-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/1634