[PATCH v2 1/2] t1401: remove lockfile creation
- From
Justin Tobler via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Jan 11, 2024, 20:24 UTC
- Message-ID
- <714f713ccece4a9dd167b3b73a71c068dbe91f53.1705004670.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.1634.v2.git.1705004670.gitgitgadget@gmail.com>
From: Justin Tobler <jltobler@gmail.com>
To create error conditions, some tests set up reference locks by directly creating its lockfile. While this works for the files reference backend, this approach is incompatible with the reftable backend. Refactor the test to create a d/f conflict via git-symbolic-ref(1) instead so that the test is reference backend agnostic.
Signed-off-by: Justin Tobler <jltobler@gmail.com> --- t/t1401-symbolic-ref.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/t/t1401-symbolic-ref.sh b/t/t1401-symbolic-ref.sh index c7745e1bf69..c67e5c134d9 100755 --- a/t/t1401-symbolic-ref.sh +++ b/t/t1401-symbolic-ref.sh @@ -106,9 +106,8 @@ test_expect_success LONG_REF 'we can parse long symbolic ref' ' ' test_expect_success 'symbolic-ref reports failure in exit code' ' - test_when_finished "rm -f .git/HEAD.lock" && - >.git/HEAD.lock && - test_must_fail git symbolic-ref HEAD refs/heads/whatever + # Create d/f conflict to simulate failure. + test_must_fail git symbolic-ref refs/heads refs/heads/foo ' test_expect_success 'symbolic-ref writes reflog entry' '
-- gitgitgadget