git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Generalize reference locking in tests

From
Justin Tobler via GitGitGadget <gitgitgadget@gmail.com>
Date
Jan 10, 2024, 18:52 UTC
Message-ID
<pull.1634.git.1704912750.gitgitgadget@gmail.com>

There are two tests in t1401 and t5541 that rely on writing a reference lock file directly. While this works for the files reference backend, reftable reference locks operate differently and are incompatible with this approach. To be reference backend agnostic, this patch series refactors the two tests to use git-update-ref(1) to lock refs instead.

This approach is more verbose and may warrant consideration of implementing an abstraction to further simplify this operation. There appears to be one other existing test in t1400 that also follows this pattern. Being that there is only a handful of affected tests the implemented approach may be sufficient as is.

Justin Tobler (2):
  t1401: generalize reference locking
  t5541: generalize reference locking
 t/t1401-symbolic-ref.sh    | 28 ++++++++++++++++++++++++----
 t/t5541-http-push-smart.sh | 25 +++++++++++++++++++++++--
 2 files changed, 47 insertions(+), 6 deletions(-)
base-commit: 624eb90fa8f65a79396615f3c2842ac5a3743350
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1634%2Fjltobler%2Fjt%2Fbackend-generic-ref-lock-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1634/jltobler/jt/backend-generic-ref-lock-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1634
-- 
gitgitgadget
Next: Justin Tobler via GitGitGadget
Message 1 of 20 in “Generalize reference locking in tests”
  1. 0/2 Generalize reference locking in testsJustin Tobler via GitGitGadget, Jan 10, 2024
  2. 1/2 t1401: generalize reference lockingJustin Tobler via GitGitGadget, Jan 10, 2024
  3. Jeff KingJan 11, 2024
  4. Patrick SteinhardtJan 11, 2024
  5. Jeff KingJan 12, 2024
  6. Patrick SteinhardtJan 12, 2024
  7. Jeff KingJan 12, 2024
  8. Justin ToblerJan 11, 2024
  9. 2/2 t5541: generalize reference lockingJustin Tobler via GitGitGadget, Jan 10, 2024
  10. Jeff KingJan 11, 2024
  11. Junio C HamanoJan 11, 2024
  12. Justin ToblerJan 11, 2024
  13. Junio C HamanoJan 11, 2024
  14. Justin ToblerJan 11, 2024
  15. 0/2 Generalize reference locking in testsJustin Tobler via GitGitGadget, Jan 11, 2024
  16. 1/2 t1401: remove lockfile creationJustin Tobler via GitGitGadget, Jan 11, 2024
  17. 2/2 t5541: remove lockfile creationJustin Tobler via GitGitGadget, Jan 11, 2024
  18. Jeff KingJan 12, 2024
  19. Junio C HamanoJan 12, 2024
  20. Justin ToblerJan 13, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.