Re: [PATCH 00/12] Group reffiles tests

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 18, 2024, 01:17 UTC
Message-ID: <xmqqv87rsan6.fsf@gitster.g>
In-Reply-To: <pull.1647.git.git.1705521155.gitgitgadget@gmail.com>

"John Cai via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 10 quoted lines

> This series groups REFFILES specific tests together. These tests are
> currently grouped together across the test suite based on functionality.
> However, since they exercise low-level behavior specific to the refs backend
> being used (in these cases, the ref-files backend), group them together
> based on which refs backend they test. This way, in the near future when the
> reftables backend gets upstreamed we can add tests that exercise the
> reftables backend close by in the t06xx area.
>
> These patches also remove the REFFILES prerequisite, since all the tests in
> t06xx are reffiles specific.

As we already have REFFILES lazy prereq, even _before_ we enable the reftable backend, I think that we should start t0600 and t0602 with

	. ./test-lib.sh
	if ! test_have_prereq REFFILES
	then
		skip_all='skipping reffiles specific tests'
		test_done
	fi

which is more in line with the existing convention. It is more efficient than "forcing t0600 and t0602 to run always with reffiles" when you have a CI job that uses reftable for all tests and another CI job that uses reffiles for all tests.

> In the near future, once the reftable backend is upstreamed, all
> the tests in t06xx will be forced to run with the reffiles
> backend.

Presumably if there are reftable backend specific tests, they will also be given names out of t06xx range, right? And then they will be skipped when the test is not using reftable as the default ref backend, using the REFTABLE prerequisite in a similar way as shown above for REFFILES, right?

Thanks.