Re: [PATCH v2 00/12] Group reffiles tests
- From
John Cai <johncai86@gmail.com>
- Date
- Jan 24, 2024, 21:37 UTC
- Message-ID
- <76D54E67-543E-4093-8D1F-3D5E208FE683@gmail.com>
- In-Reply-To
- <xmqqplxsrk8n.fsf@gitster.g>
Hi Junio,
On 22 Jan 2024, at 19:01, Junio C Hamano wrote:
Show 9 quoted lines
> Patrick Steinhardt <ps@pks.im> writes: > >> I've got two minor nits, but other than that this looks good to me. I've >> also verified that all tests continue to pass with the current version >> of the reftable backend. > > OK. I've squashed all the nits from you and Karthik into the copy > in my tree. If there is nothing else, let's declare a victory and > merge the topic down to 'next' soonish.
Thank you for doing these tedious corrections!
Show 10 quoted lines
> >> There's a minor merge conflict with db4192c364 (t: mark tests regarding >> git-pack-refs(1) to be backend specific, 2024-01-10). This conflict >> comes from the fact that both patch series add the REFFILES prereq to >> t3210, semantically the changes are the same. So it doesn't quite matter >> which of both versions we retain as they both do the same. > > Yup, that is what I've been resolving them. > > Thanks.
thanks John