git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 12/12] t5312: move reffiles specific tests to t0600

From
Patrick Steinhardt <ps@pks.im>
Date
Jan 19, 2024, 13:40 UTC
Message-ID
<Zap7wPW8qwHRuCM0@tanuki>
In-Reply-To
<316a20ed17950e4e45d7ea13d8f6e8d4e064821e.1705521155.git.gitgitgadget@gmail.com>
On Wed, Jan 17, 2024 at 07:52:35PM +0000, John Cai via GitGitGadget wrote:
Show 48 quoted lines
> From: John Cai <johncai86@gmail.com>
> 
> Move a few tests into t0600 since they specifically test the packed-refs
> file and thus are specific to the reffiles backend.
> 
> Signed-off-by: John Cai <johncai86@gmail.com>
> ---
>  t/t0600-reffiles-backend.sh | 30 ++++++++++++++++++++++++++++++
>  t/t5312-prune-corruption.sh | 26 --------------------------
>  2 files changed, 30 insertions(+), 26 deletions(-)
> 
> diff --git a/t/t0600-reffiles-backend.sh b/t/t0600-reffiles-backend.sh
> index c88576dfea5..190155f592d 100755
> --- a/t/t0600-reffiles-backend.sh
> +++ b/t/t0600-reffiles-backend.sh
> @@ -571,4 +571,34 @@ test_expect_success 'log diagnoses bogus HEAD symref' '
>  	test_grep broken stderr
>  '
>  
> +# we do not want to count on running pack-refs to
> +# actually pack it, as it is perfectly reasonable to
> +# skip processing a broken ref
> +test_expect_success 'create packed-refs file with broken ref' '
> +	test_tick && git commit --allow-empty -m one &&
> +	recoverable=$(git rev-parse HEAD) &&
> +	test_tick && git commit --allow-empty -m two &&
> +	missing=$(git rev-parse HEAD) &&
> +	rm -f .git/refs/heads/main &&
> +	cat >.git/packed-refs <<-EOF &&
> +	$missing refs/heads/main
> +	$recoverable refs/heads/other
> +	EOF
> +	echo $missing >expect &&
> +	git rev-parse refs/heads/main >actual &&
> +	test_cmp expect actual
> +'
> +
> +test_expect_success 'pack-refs does not silently delete broken packed ref' '
> +	git pack-refs --all --prune &&
> +	git rev-parse refs/heads/main >actual &&
> +	test_cmp expect actual
> +'
> +
> +test_expect_success  'pack-refs does not drop broken refs during deletion' '
> +	git update-ref -d refs/heads/other &&
> +	git rev-parse refs/heads/main >actual &&
> +	test_cmp expect actual
> +'
Should these tests be moved into t0601-reffiles-pack-refs.sh instead?
Patrick
Previous: John Cai via GitGitGadgetNext: Junio C Hamano
Message 24 of 47 in “Group reffiles tests”
  1. 00/12 Group reffiles testsJohn Cai via GitGitGadget, Jan 17, 2024
  2. 01/12 t3210: move to t0602John Cai via GitGitGadget, Jan 17, 2024
  3. Junio C HamanoJan 18, 2024
  4. Patrick SteinhardtJan 18, 2024
  5. John CaiJan 18, 2024
  6. 02/12 remove REFFILES prerequisiteJohn Cai via GitGitGadget, Jan 17, 2024
  7. Junio C HamanoJan 18, 2024
  8. Patrick SteinhardtJan 18, 2024
  9. 03/12 t1414: convert test to use Git commands instead of writing refs manuallyJohn Cai via GitGitGadget, Jan 17, 2024
  10. Junio C HamanoJan 18, 2024
  11. 05/12 t1405: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 17, 2024
  12. 04/12 t1404: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 17, 2024
  13. Patrick SteinhardtJan 19, 2024
  14. 06/12 t1406: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 17, 2024
  15. 07/12 t1410: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 17, 2024
  16. 08/12 t1415: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 17, 2024
  17. Patrick SteinhardtJan 19, 2024
  18. 09/12 t1503: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 17, 2024
  19. 10/12 t3903: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 17, 2024
  20. Patrick SteinhardtJan 19, 2024
  21. John CaiJan 19, 2024
  22. 11/12 t4202: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 17, 2024
  23. 12/12 t5312: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 17, 2024
  24. Patrick SteinhardtJan 19, 2024
  25. Junio C HamanoJan 18, 2024
  26. Patrick SteinhardtJan 18, 2024
  27. Junio C HamanoJan 18, 2024
  28. 00/12 Group reffiles testsJohn Cai via GitGitGadget, Jan 19, 2024
  29. 01/12 t3210: move to t0601John Cai via GitGitGadget, Jan 19, 2024
  30. Patrick SteinhardtJan 22, 2024
  31. 02/12 remove REFFILES prerequisite for some tests in t1405 and t2017John Cai via GitGitGadget, Jan 19, 2024
  32. 03/12 t1414: convert test to use Git commands instead of writing refs manuallyJohn Cai via GitGitGadget, Jan 19, 2024
  33. 05/12 t1405: move reffiles specific tests to t0601John Cai via GitGitGadget, Jan 19, 2024
  34. 04/12 t1404: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 19, 2024
  35. Patrick SteinhardtJan 22, 2024
  36. 06/12 t1406: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 19, 2024
  37. 07/12 t1410: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 19, 2024
  38. Karthik NayakJan 22, 2024
  39. 08/12 t1415: move reffiles specific tests to t0601John Cai via GitGitGadget, Jan 19, 2024
  40. Karthik NayakJan 22, 2024
  41. 09/12 t1503: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 19, 2024
  42. 10/12 t3903: make drop stash test ref backend agnosticJohn Cai via GitGitGadget, Jan 19, 2024
  43. 11/12 t4202: move reffiles specific tests to t0600John Cai via GitGitGadget, Jan 19, 2024
  44. 12/12 t5312: move reffiles specific tests to t0601John Cai via GitGitGadget, Jan 19, 2024
  45. Patrick SteinhardtJan 22, 2024
  46. Junio C HamanoJan 23, 2024
  47. John CaiJan 24, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.