git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 3/6] update-ref: add support for 'symref-delete' command

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 5, 2024, 16:22 UTC
Message-ID
<xmqqv82nuzpv.fsf@gitster.g>
In-Reply-To
<ZmAbgGfNpZzU76pd@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
Show 33 quoted lines
>> +	test_expect_success "stdin $type symref-delete fails with wrong old value" '
>> +		format_command $type "symref-delete refs/heads/symref" "$m" >stdin &&
>> +		test_must_fail git update-ref --stdin $type --no-deref <stdin 2>err &&
>> +		grep "fatal: verifying symref target: ${SQ}refs/heads/symref${SQ}: is at $a but expected refs/heads/main" err &&
>> +		git symbolic-ref refs/heads/symref >expect &&
>> +		echo $a >actual &&
>> +		test_cmp expect actual
>> +	'
>> +
>> +	test_expect_success "stdin $type symref-delete works with right old value" '
>> +		format_command $type "symref-delete refs/heads/symref" "$a" >stdin &&
>> +		git update-ref --stdin $type --no-deref <stdin &&
>> +		test_must_fail git rev-parse --verify -q refs/heads/symref
>> +	'
>> +
>> +	test_expect_success "stdin $type symref-delete works with empty old value" '
>> +		git symbolic-ref refs/heads/symref $a >stdin &&
>> +		format_command $type "symref-delete refs/heads/symref" "" >stdin &&
>> +		git update-ref --stdin $type --no-deref <stdin &&
>> +		test_must_fail git rev-parse --verify -q $b
>> +	'
>> +
>> +	test_expect_success "stdin $type symref-delete succeeds for dangling reference" '
>> +		test_must_fail git symbolic-ref refs/heads/nonexistent &&
>> +		git symbolic-ref refs/heads/symref2 refs/heads/nonexistent &&
>> +		format_command $type "symref-delete refs/heads/symref2" "refs/heads/nonexistent" >stdin &&
>> +		git update-ref --stdin $type --no-deref <stdin &&
>> +		test_must_fail git symbolic-ref -d refs/heads/symref2
>> +	'
>> +
>
> Not sure whether I overlooked it, but one test I missed was when trying
> to delete a non-symbolic-ref.

Hmph, so we want to see an attempt to run symref-delete of refs/heads/main when refs/heads/main is *not* a symref to fail? That is a reasonable test to have.

When you invent a shiny new toy, it is hard to make sure you covered cases where it should not kick in or positively diagnose a failure. A review with a sharp eye to spot missing tests is very much appreciated.

THanks.
Previous: Karthik NayakNext: Karthik Nayak
Message 45 of 50 in “update-ref: add symref support for --stdin”
  1. 0/6 update-ref: add symref support for --stdinKarthik Nayak, May 14, 2024
  2. 1/6 refs: create and use `ref_update_ref_must_exist()`Karthik Nayak, May 14, 2024
  3. Patrick SteinhardtMay 16, 2024
  4. Karthik NayakMay 17, 2024
  5. 2/6 update-ref: add support for 'symref-verify' commandKarthik Nayak, May 14, 2024
  6. Patrick SteinhardtMay 16, 2024
  7. Karthik NayakMay 17, 2024
  8. Patrick SteinhardtMay 21, 2024
  9. 3/6 update-ref: add support for 'symref-delete' commandKarthik Nayak, May 14, 2024
  10. Patrick SteinhardtMay 16, 2024
  11. 4/6 update-ref: add support for 'symref-create' commandKarthik Nayak, May 14, 2024
  12. Patrick SteinhardtMay 16, 2024
  13. Karthik NayakMay 19, 2024
  14. 5/6 reftable: pick either 'oid' or 'target' for new updatesKarthik Nayak, May 14, 2024
  15. 6/6 update-ref: add support for 'symref-update' commandKarthik Nayak, May 14, 2024
  16. Patrick SteinhardtMay 16, 2024
  17. Karthik NayakMay 21, 2024
  18. Karthik NayakMay 22, 2024
  19. 0/6 update-ref: add symref support for --stdinKarthik Nayak, May 22, 2024
  20. 1/6 refs: create and use `ref_update_expects_existing_old_ref()`Karthik Nayak, May 22, 2024
  21. 2/6 update-ref: add support for 'symref-verify' commandKarthik Nayak, May 22, 2024
  22. 3/6 update-ref: add support for 'symref-delete' commandKarthik Nayak, May 22, 2024
  23. 4/6 update-ref: add support for 'symref-create' commandKarthik Nayak, May 22, 2024
  24. 5/6 reftable: pick either 'oid' or 'target' for new updatesKarthik Nayak, May 22, 2024
  25. 6/6 update-ref: add support for 'symref-update' commandKarthik Nayak, May 22, 2024
  26. Junio C HamanoMay 25, 2024
  27. Karthik NayakMay 29, 2024
  28. Junio C HamanoMay 23, 2024
  29. Karthik NayakMay 23, 2024
  30. Junio C HamanoMay 23, 2024
  31. Karthik NayakMay 23, 2024
  32. Eric SunshineMay 23, 2024
  33. Junio C HamanoMay 23, 2024
  34. Eric SunshineMay 23, 2024
  35. Junio C HamanoMay 23, 2024
  36. Junio C HamanoMay 23, 2024
  37. Junio C HamanoMay 23, 2024
  38. 0/6 update-ref: add symref support for --stdinKarthik Nayak, May 30, 2024
  39. Patrick SteinhardtJun 5, 2024
  40. 1/6 refs: create and use `ref_update_expects_existing_old_ref()`Karthik Nayak, May 30, 2024
  41. 2/6 update-ref: add support for 'symref-verify' commandKarthik Nayak, May 30, 2024
  42. 3/6 update-ref: add support for 'symref-delete' commandKarthik Nayak, May 30, 2024
  43. Patrick SteinhardtJun 5, 2024
  44. Karthik NayakJun 5, 2024
  45. Junio C HamanoJun 5, 2024
  46. 4/6 update-ref: add support for 'symref-create' commandKarthik Nayak, May 30, 2024
  47. Patrick SteinhardtJun 5, 2024
  48. 5/6 reftable: pick either 'oid' or 'target' for new updatesKarthik Nayak, May 30, 2024
  49. 6/6 update-ref: add support for 'symref-update' commandKarthik Nayak, May 30, 2024
  50. Patrick SteinhardtJun 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.