Re: [PATCH v2 0/6] update-ref: add symref support for --stdin

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 23, 2024, 18:50 UTC
Message-ID: <CAPig+cT71R1qYTkshvQNpOepOskz3LNDCc4eiih-8H9LDJmf-A@mail.gmail.com>
In-Reply-To: <xmqqo78wtn7y.fsf@gitster.g>

On Thu, May 23, 2024 at 2:08 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Eric Sunshine <sunshine@sunshineco.com> writes:
> > On Thu, May 23, 2024 at 12:29 PM Junio C Hamano <gitster@pobox.com> wrote:
> >> We may want to teach "format-patch --range-diff" to place the output
> >> of range-diff _below_ the list of commits and the overall diffstat
> >> in the cover letter
> >
> > Placing the range-diff below the list of commits and the overall
> > diffstat in the cover letter is how `format-patch --range-diff`
> > already works.
>
> Heh, so what Karthik was manually doing made the cover letter harder
> to read?

Apparently so.

> In any case, that is a great news.

Placement of the range-diff in the cover-letter was a deliberate choice[1].

> >> (and at the end of the patch for a single patch topic).
> >
> > This could indeed lead to less visual clutter for the single-patch topic.

Regarding your experiment[2] to place the range-diff at the end of a single-patch, apparently that idea had been considered, as well, but it was noted[3,4] that, by default, some MUIs hide everything after the "--" line.

[1]: https://lore.kernel.org/git/CAPig+cT9zCcNxn1+DPMQWqJ-hfxb7gE7rKyfbqHjTC+FDNY_mw@mail.gmail.com/ [2]: https://lore.kernel.org/git/xmqqh6ep1pwz.fsf_-_@gitster.g/ [3]: https://lore.kernel.org/git/xmqqmuupogei.fsf@gitster-ct.c.googlers.com/ [4]: https://lore.kernel.org/git/CAPig+cRx5-2TYOm_8oayFfbKGpmTJf=M0cNR3L5UJGGC6vHPDQ@mail.gmail.com/