Re: [PATCH v2 0/6] update-ref: add symref support for --stdin

From: Junio C Hamano <gitster@pobox.com>
Date: May 23, 2024, 15:02 UTC
Message-ID: <xmqqbk4wy3ji.fsf@gitster.g>
In-Reply-To: <20240522090326.1268326-1-knayak@gitlab.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 5 quoted lines

> The patches 1, 5 fix small issues in the reference backends. The other
> patches 2, 3, 4 & 6, each add one of the new sub-commands.
>
> The series is based off master, with 'kn/ref-transaction-symref' merged
> in. There seem to be no conflicts with 'next' or 'seen'.

Wait.  There is something fishy going on.

Show 10 quoted lines

> Range diff vs v1:
>  1:  1bc4cc3fc4 =  1:  1bc4cc3fc4 refs: accept symref values in `ref_transaction_update()`
>  2:  57d0b1e2ea =  2:  57d0b1e2ea files-backend: extract out `create_symref_lock()`
>  3:  a8ae923f85 =  3:  a8ae923f85 refs: support symrefs in 'reference-transaction' hook
>  4:  e9965ba477 =  4:  e9965ba477 refs: move `original_update_refname` to 'refs.c'
>  5:  644daf7785 =  5:  644daf7785 refs: add support for transactional symref updates
>  6:  300b38e46f =  6:  300b38e46f refs: use transaction in `refs_create_symref()`
>  7:  f151dfe3c9 =  7:  f151dfe3c9 refs: rename `refs_create_symref()` to `refs_update_symref()`
>  8:  4865707bda =  8:  4865707bda refs: remove `create_symref` and associated dead code
>  9:  4cb67dce7c !  9:  2bbdeff798 refs: create and use `ref_update_ref_must_exist()`

4865707bda has been part of 'next' since 0a7119f2 (Merge branch 'kn/ref-transaction-symref' into next, 2024-05-11) and was merged to 'master' with 4beb7a3b (Merge branch 'kn/ref-transaction-symref', 2024-05-20).

I am confused why we are seeing a total reroll of such an old topic.

Also you have one more patch at the end. Neither the before or after version of 9/9.

Is this actually a single patch submission of 9/9 alone? Patches 1-8/9 are all old ones that are in 'master' already.

Puzzled...