Re: [PATCH v3] format-patch: assume --cover-letter for diff in multi-patch series

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 5, 2024, 21:52 UTC
Message-ID: <xmqqv82noy5m.fsf@gitster.g>
In-Reply-To: <5aebe520-e540-46b4-a887-af488fe2663a@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

Show 8 quoted lines

> I'm curious, a test like: 
>
> test_expect_success "format-patch --range-diff, implicit --cover-letter" '
> 	test_when_finished "rm v2-000?-*" &&
> 	test_must_fail git format-patch --no-cover-letter
> 		-v2 --range-diff=topic main..unmodified
>
> isn't it confusing?

It is, but what makes it confusing is that the title does not describe what it tests, no? It tests that --no-cover-letter disables implicit cover-letter generation even with the presence of --range-diff.

In the context of t3206-range-diff.sh, we know we are talking about the "range-diff", and mention of "cover-letter" is a hint enough that the "format-patch" is involved, so perhaps titles like

    test_expect_success 'explicit --no-cover-letter defeats implied --cover-letter'

and

    test_expect_success '--cover-letter is implied for multi-patch series'

would be clear enough and convey what the tests are actually doing.