Re: [PATCH] format-patch: assume --cover-letter for diff in multi-patch series

From: Patrick Steinhardt <ps@pks.im>
Date: Jun 4, 2024, 08:02 UTC
Message-ID: <Zl7J_Xr6Z7Ot6Hlk@framework>
In-Reply-To: <6269eed5-f1ff-43f3-9249-d6a0f1852a6c@gmail.com>

On Tue, Jun 04, 2024 at 12:49:35AM +0200, Rubén Justo wrote:

Show 8 quoted lines

> If either `--interdiff` or `--range-diff` is specified without
> `--cover-letter`, we'll abort if it would result in a multi-patch series
> being generated.  Because the cover-letter is needed to give the diff
> text in a multi-patch series.
> 
> Considering that `format-patch` generates a multi-patch as needed, let's
> adopt a similar "cover as necessary" approach when using `--interdiff`
> or `--range-diff`.

What does git-format-patch(1) do right now in this situation?

In any case, this change should probably have a test or two to demonstrate that it works as advertised.

Thanks!

Patrick