Re: [PATCH] gitk: use mktemp -d to avoid predictable temporary directories
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 16, 2014, 18:17 UTC
- Message-ID
- <xmqqtx7kra5x.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20140615214928.GA619@gmail.com>
David Aguilar <davvid@gmail.com> writes:
> Hmm.. I guess what I could do is keep the old behavior (having gitk ignore TMPDIR) > on Windows and only use the new code path on non-Windows.
Or perhaps attempt to create, catch error and then retry the old way?
Hopefully Windows folks do not have to worry about forgetting to update the codepath when they update their tcl/wish if you did it that way, no?
> > That seems like it'd be the simplest implementation (no need to check versions) > and the least harmful to existing users (avoids a tcl upgrade or mkdtemp installation > for Windows users).