git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: use mktemp -d to avoid predictable temporary directories

From
David Aguilar <davvid@gmail.com>
Date
Jun 19, 2014, 02:54 UTC
Message-ID
<20140619025406.GA8660@gmail.com>
In-Reply-To
<xmqqtx7kra5x.fsf@gitster.dls.corp.google.com>
On Mon, Jun 16, 2014 at 11:17:46AM -0700, Junio C Hamano wrote:
Show 10 quoted lines
> David Aguilar <davvid@gmail.com> writes:
> 
> > Hmm.. I guess what I could do is keep the old behavior (having gitk ignore TMPDIR)
> > on Windows and only use the new code path on non-Windows.
> 
> Or perhaps attempt to create, catch error and then retry the old way?
> 
> Hopefully Windows folks do not have to worry about forgetting to
> update the codepath when they update their tcl/wish if you did it
> that way, no?

True, that would be the safest. I just submitted a new replacement patch for these two patches.

Thanks,
-- 
David
Previous: Junio C HamanoNext: Thomas Braun
Message 8 of 9 in “gitk: use mktemp -d to avoid predictable temporary directories”
  1. gitk: use mktemp -d to avoid predictable temporary directoriesDavid Aguilar, Jun 13, 2014
  2. Paul MackerrasJun 15, 2014
  3. Pat ThoytsJun 15, 2014
  4. brian m. carlsonJun 15, 2014
  5. David AguilarJun 15, 2014
  6. brian m. carlsonJun 15, 2014
  7. Junio C HamanoJun 16, 2014
  8. David AguilarJun 19, 2014
  9. Thomas BraunJun 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.