git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: use mktemp -d to avoid predictable temporary directories

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jun 15, 2014, 22:16 UTC
Message-ID
<20140615221632.GH368384@vauxhall.crustytoothpaste.net>
In-Reply-To
<20140615214928.GA619@gmail.com>
On Sun, Jun 15, 2014 at 02:49:29PM -0700, David Aguilar wrote:
> I don't think this requires a CVE since it's basically plugging a hole
> that my previous patch introduced by making gitk honor the TMPDIR
> variable; it hasn't strictly been in any release yet.

Yeah, that's not needed, then. I didn't notice it was the immediately previous patch. My bad.

Show 7 quoted lines
> Hmm.. I guess what I could do is keep the old behavior (having gitk
> ignore TMPDIR) on Windows and only use the new code path on
> non-Windows.
> 
> That seems like it'd be the simplest implementation (no need to check
> versions) and the least harmful to existing users (avoids a tcl
> upgrade or mkdtemp installation for Windows users).

Yeah, that would be the safest bet. Maybe a comment to that effect would be appropriate, so that when Tcl gets upgraded, that change can be removed.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Previous: David AguilarNext: Junio C Hamano
Message 6 of 9 in “gitk: use mktemp -d to avoid predictable temporary directories”
  1. gitk: use mktemp -d to avoid predictable temporary directoriesDavid Aguilar, Jun 13, 2014
  2. Paul MackerrasJun 15, 2014
  3. Pat ThoytsJun 15, 2014
  4. brian m. carlsonJun 15, 2014
  5. David AguilarJun 15, 2014
  6. brian m. carlsonJun 15, 2014
  7. Junio C HamanoJun 16, 2014
  8. David AguilarJun 19, 2014
  9. Thomas BraunJun 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.