git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Allow building Git with Asciidoctor

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 13, 2014, 20:41 UTC
Message-ID
<xmqqtx371z44.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1413070656-241955-1-git-send-email-sandals@crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 13 quoted lines
> This series is designed to implement the changes necessary to build Git
> using Asciidoctor instead of AsciiDoc.
>
> The first two patches are bug fixes.  Asciidoctor is stricter about
> title underline lengths (± 1 character instead of 2) and requires
> matching delimiter lengths[0].  They're needed regardless of whether the
> other two patches are accepted because git-scm.com uses Asciidoctor to
> render the documentation, so we might as well render it correctly.
>
> Even with these patches, Asciidoctor warns about everyday.txt and
> user-manual.txt.  I'm not sending patches for these right now because
> I've seen recent series including those and don't want to cause a
> merge conflict.
Sounds good.
Show 8 quoted lines
> The second two patches implement some basic support for building with
> Asciidoctor.  The first of these moves some items into variables due to
> some differences between the AsciiDoc and Asciidoctor command lines.
> The user can then override these values when invoking make.
>
> The final patch adds support for the linkgit macro.  Asciidoctor uses
> Ruby extensions to implement macro support, unlike AsciiDoc, which uses
> a configuration file.

What I do not understand is that 3/4 lets you drop inclusion of asciidoc.conf which contains a lot more than just linkgit: definition.

For now I'll queue only the first two, which unquestionably take us in the right direction.

Thanks.
Previous: brian m. carlsonNext: brian m. carlson
Message 9 of 19 in “Allow building Git with Asciidoctor”
  1. 0/4 Allow building Git with Asciidoctorbrian m. carlson, Oct 11, 2014
  2. 1/4 Documentation: adjust document title underliningbrian m. carlson, Oct 11, 2014
  3. Junio C HamanoOct 13, 2014
  4. 2/4 Documentation: fix mismatched delimiters in git-imap-sendbrian m. carlson, Oct 11, 2014
  5. 3/4 Documentation: move some AsciiDoc parameters into variablesbrian m. carlson, Oct 11, 2014
  6. Junio C HamanoOct 15, 2014
  7. brian m. carlsonOct 16, 2014
  8. 4/4 Documentation: implement linkgit macro for Asciidoctorbrian m. carlson, Oct 11, 2014
  9. Junio C HamanoOct 13, 2014
  10. brian m. carlsonOct 14, 2014
  11. Jakub NarębskiOct 14, 2014
  12. brian m. carlsonOct 14, 2014
  13. Jeff KingOct 14, 2014
  14. Junio C HamanoOct 14, 2014
  15. brian m. carlsonOct 15, 2014
  16. Junio C HamanoOct 15, 2014
  17. Thomas BraunOct 15, 2014
  18. brian m. carlsonOct 15, 2014
  19. Philip OakleyOct 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.