git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Allow building Git with Asciidoctor

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Oct 15, 2014, 01:17 UTC
Message-ID
<20141015011754.GA131351@vauxhall.crustytoothpaste.net>
In-Reply-To
<xmqqsiiqziik.fsf@gitster.dls.corp.google.com>
On Tue, Oct 14, 2014 at 10:08:19AM -0700, Junio C Hamano wrote:
Show 21 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > On Sat, Oct 11, 2014 at 11:37:32PM +0000, brian m. carlson wrote:
> >
> > Specifically I'm not excited about getting into a state where we have to
> > maintain both an asciidoc.conf file _and_ ruby extensions for
> > asciidoctor. I don't mind if somebody wants to step up and keep the
> > asciidoctor bits in sync with the asciidoc.conf, but I feel like one of
> > them needs to be considered the "master".
> 
> My so-far-unstated inclination, since seeing the patch to fix the
> unbalanced example block separators from Brian (which was outside
> and before this four-patch series), has been to keep our Makefile in
> Documentation/ aware only of AsciiDoc while maintaining *.txt files
> in a state so that AsciiDoctor could also be used to process them,
> if people want to futz with their copies of Documentation/Makefile.
> 
> I do not mind to have the machinery to run AsciiDoctor too much in
> my tree.  It may make it easier for those who use it to spot places
> in *.txt that need (in)compatibility workarounds between the two
> formatters than keeping it outside.

I'd be happy if you simply picked up patch 3 and left out patch 4. It gets us most of the way there, which is good enough for most things. It's even possible to handle the litdd attribute on the command line, so the only thing we'd really lose is the linkgit links.

Alternately, I'm happy to be responsible for maintaining the extensions.rb file. The asciidoc.conf file has not had a substantive (non-comment) change since 2012, and it has not had a change that would require an update to the extensions since 2010. I don't anticipate that keeping it up-to-date will require a significant amount of work. We can even drop it into contrib if you think that's a better place.

It's really up to you which you'd prefer.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Previous: Junio C HamanoNext: Junio C Hamano
Message 15 of 19 in “Allow building Git with Asciidoctor”
  1. 0/4 Allow building Git with Asciidoctorbrian m. carlson, Oct 11, 2014
  2. 1/4 Documentation: adjust document title underliningbrian m. carlson, Oct 11, 2014
  3. Junio C HamanoOct 13, 2014
  4. 2/4 Documentation: fix mismatched delimiters in git-imap-sendbrian m. carlson, Oct 11, 2014
  5. 3/4 Documentation: move some AsciiDoc parameters into variablesbrian m. carlson, Oct 11, 2014
  6. Junio C HamanoOct 15, 2014
  7. brian m. carlsonOct 16, 2014
  8. 4/4 Documentation: implement linkgit macro for Asciidoctorbrian m. carlson, Oct 11, 2014
  9. Junio C HamanoOct 13, 2014
  10. brian m. carlsonOct 14, 2014
  11. Jakub NarębskiOct 14, 2014
  12. brian m. carlsonOct 14, 2014
  13. Jeff KingOct 14, 2014
  14. Junio C HamanoOct 14, 2014
  15. brian m. carlsonOct 15, 2014
  16. Junio C HamanoOct 15, 2014
  17. Thomas BraunOct 15, 2014
  18. brian m. carlsonOct 15, 2014
  19. Philip OakleyOct 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.