Re: [PATCH v5] remote: add get-url subcommand
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 16, 2015, 22:51 UTC
- Message-ID
- <xmqqtwqukmet.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1442368427-3311-1-git-send-email-mathstuf@gmail.com>
Ben Boeckel <mathstuf@gmail.com> writes:
Show 7 quoted lines
> +get_url_test () {
> + cat >expect &&
> + test_expect_success "get-url $*" "
> + git remote get-url $* >actual &&
> + test_cmp expect actual
> + "
> +}This makes any use of get_url_test inside test_expect_success wrong, I suspect. Try running the tests under prove. I think it will complain that the test numbers do not match or something.
Minimally, this would probably fix the breakage.
t/t5505-remote.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh index f03ba4c..dfaf9d9 100755 --- a/t/t5505-remote.sh +++ b/t/t5505-remote.sh @@ -921,10 +921,8 @@ test_expect_success 'new remote' ' get_url_test () { cat >expect && - test_expect_success "get-url $*" " - git remote get-url $* >actual && - test_cmp expect actual - " + git remote get-url "$@" >actual && + test_cmp expect actual } test_expect_success 'get-url on new remote' '