Re: [PATCH v3] remote: add get-url subcommand
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 5, 2015, 20:34 UTC
- Message-ID
- <xmqqio8t325x.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1438700198-4942-1-git-send-email-mathstuf@gmail.com>
Ben Boeckel <mathstuf@gmail.com> writes:
Show 9 quoted lines
> Expanding `insteadOf` is a part of ls-remote --url and there is no way > to expand `pushInsteadOf` as well. Add a get-url subcommand to be able > to query both as well as a way to get all configured urls. > > Signed-off-by: Ben Boeckel <mathstuf@gmail.com> > --- > Documentation/git-remote.txt | 10 ++++++++ > builtin/remote.c | 54 ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 64 insertions(+)
Changes to these two files look reasonable.
Don't you want to protect this feature from future breakage by others by adding a couple of tests, though, to t/t5505?
Thanks.