Re: [PATCH v3] remote: add get-url subcommand

From: Ben Boeckel <mathstuf@gmail.com>
Date: Aug 5, 2015, 21:33 UTC
Message-ID: <20150805213358.GA2592@megas.kitware.com>
In-Reply-To: <xmqqio8t325x.fsf@gitster.dls.corp.google.com>

On Wed, Aug 05, 2015 at 13:34:18 -0700, Junio C Hamano wrote:

> Changes to these two files look reasonable.
> 
> Don't you want to protect this feature from future breakage by
> others by adding a couple of tests, though, to t/t5505?

Thanks, I've done so locally. It actually brings up this case:

    $ git remote add someremote foo
    $ git remote get-url --push someremote
    fatal: no URLs configured for remote 'someremote'

Is it better to use:

    remote = remote_get(remotename);
    remote->pushurl;

    if (remote->pushurl_nr)
        remote->pushurl;
    else
        remote->url;

or:

    remote = pushremote_get(remotename);
    remote->pushurl;

? What is the actual difference between the two?

Thanks,

--Ben