Re: [PATCH] git-p4.py: Make submit working on bare repository
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 12, 2016, 23:25 UTC
- Message-ID
- <xmqqtwj6mmtu.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAE5ih7-q_PwF-T6nsu=FyyN9wO6o0Jcfkg=gKy5mhOXRGFZ+VA@mail.gmail.com>
Luke Diamand <luke@diamand.org> writes:
Show 19 quoted lines
> On 28 February 2016 at 20:46, Amadeusz Żołnowski <aidecoe@aidecoe.name> wrote: > >> >> True. For now I have these cases covered by wrapper scripts. The minimum >> I need from git-p4 is just not to fail on git submit from bare >> repository which is covered by patch I have submitted. If I get my >> solution enough testing, I'd think of transforming it into patch for >> git-p4.py as well. > > Could you change the patch to add a command-line option to suppress > the rebase? I think this would be a bit more obvious: instead of > having some special magical behaviour kick-in on a bare repo, git-p4 > just does what it's told on the command-line. > > It means that if we find another situation where we don't want to > rebase, we don't have an ever-growing list of special-case > circumstances, which could become hard to make sense of in future. > Instead, the user (who hopefully knows better) just tells git-p4 what > to do.
Has anything happened to this topic after this? I am wondering if I should discard the topic az/p4-bare-no-rebase without prejudice.
Thanks.