Re: [PATCH] git-p4.py: Make submit working on bare repository

From: Luke Diamand <luke@diamand.org>
Date: Feb 28, 2016, 04:26 UTC
Message-ID: <CAE5ih7-rBuipoAGEnK60iidi1nYA9xWZQV6jRMHTVQe6f=cQag@mail.gmail.com>
In-Reply-To: <871t83cfi7.fsf@freja.aidecoe.name>

On 23 February 2016 at 20:56, Amadeusz Żołnowski <aidecoe@aidecoe.name> wrote:

Show 5 quoted lines

>
> To simplify things, why not just update ref during submit from bare
> repository? As you have pointed out, if user invokes submit in this
> context he/she actually wants to submit from bare repo and probably
> knows what he/she is doing - especially if he/she reads man page. (-:

Will it do something sensible if anything goes wrong?

I'm thinking about what happens if you submit and one of the commits fails to go to P4 due to a merge conflict.

But I guess just doing an update-ref could be an OK thing to do. Without actually trying it out for real though I can't be sure. It might make sense to get some practical experience of how this works out.

Luke