Re: [PATCH] git-p4.py: Make submit working on bare repository

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 23, 2016, 06:59 UTC
Message-ID: <xmqqegc33oal.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <877fhwd1g0.fsf@freja.aidecoe.name>

Amadeusz Żołnowski <aidecoe@aidecoe.name> writes:

Show 11 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>> I wonder if it makes sense to just silently allowing submit without
>> rebasing, and without telling the user how to clean it up.
>
> It is a good point. Maybe submit shouldn't be allowed by default at all
> From bare repository. What do you think about following approach?  If
> core.base is true, then if git-p4.submitFromBare is also true then
> submit without performing proper rebase, but update master ref from
> p4/master. If core.base is true, but git-p4.submitFromBare is false,
> abort immediately. Submitting from bare repository would require aware
> decision from a user.

(I think you meant "bare" where you wrote "base" in the above).

As a non user of git-p4, the above sounds a safe and sensible approach, but I'd like to hear from Luke, who has been active in this area and is far more expert than I am ;-)

Thanks.