Re: [PATCH 4/4] sequencer: use trailer's trailer layout

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 1, 2016, 18:16 UTC
Message-ID: <xmqqtwbroykt.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <a416ab9b-ff1f-9a71-3e58-60fd4f8a6b8e@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 8 quoted lines

>>>  9:I want to mention about Signed-off-by: here.
>> ...
>> This seems a bit weird.
>
> This is because the "I want to mention" block has 100% trailer lines
> (since its only line contains a colon). We could forbid spaces in
> trailer field names, but as you said [1], it might be better to allow
> them since users might include them.

That merely means that the implementation of the wish expressed in [1] was overly loose and needs a bit of tightening, isn't it?

> The original sequencer.c interpreted this block as not a trailer
> block, because it only accepted alphanumeric characters or '-' before
> the colon (and no spaces) - hence the difference in behavior.

That sounds more sensible to me. Would there be an easy way to still allow misspelled "Thanks to:" but not be fooled by an obvious nonsense like this example, without going deep into natural language processing? If not, we may want to tighten it back.

>
> [1] <xmqqbmyhr4vt.fsf@gitster.mtv.corp.google.com>