Re: [PATCH v2 1/5] trailer: be stricter in parsing separators

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 1, 2016, 21:26 UTC
Message-ID: <xmqq4m3qopsh.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <0b3e70fe-5e1f-7aaa-4c3d-88f30cb15008@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 8 quoted lines

>>> Hmph.  The optional whitespace is to allow for what kind of line?
>>>
>>> It is not for "Signed off by:" that is a misspelt "Signed-off-by:";
>>> it may not hurt but I do not think of a case that would be useful
>>> offhand.
>
> This is to allow trailers of the form "Fix #42" (mentioned in the
> git-interpret-trailers documentation and also in the test).

That piece of information belongs to the in-code comment for the function, I would think. The comment that describes what it does (i.e. "token with optional spaces and separator") can be read from the code easily, but the reason why the code implements that behaviour cannot.

Thanks.