Re: [PATCH v2 1/5] trailer: be stricter in parsing separators

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 1, 2016, 20:37 UTC
Message-ID: <xmqqr36vndgn.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqvaw7ndow.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> Jonathan Tan <jonathantanmy@google.com> writes:
>
>> Currently, a line is interpreted to be a trailer line if it contains a
>> separator. Make parsing stricter by requiring the text on the left of
>> the separator, if not the empty string, to be of the "<token><optional
>> whitespace>" form.
>
> Hmph.  The optional whitespace is to allow for what kind of line?
>
> It is not for "Signed off by:" that is a misspelt "Signed-off-by:";
> it may not hurt but I do not think of a case that would be useful
> offhand.

Other than this "Hmph" (which is not an objection---just something that the reviewer did not understand), the rest looked good to me.

Will re-queue.

Thanks.