Re: [PATCH] am: add am.signoff add config variable

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 29, 2016, 21:42 UTC
Message-ID: <xmqqtw9m5s5m.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161229084701.GA3643@starla>

Eric Wong <e@80x24.org> writes:

Show 9 quoted lines

> Eduardo Habkost <ehabkost@redhat.com> wrote:
>> git-am has options to enable --message-id and --3way by default,
>> but no option to enable --signoff by default. Add a "am.signoff"
>> config option.
>
> I'm not sure this is a good idea.  IANAL, but a sign-off
> has some sort of legal meaning for this project (DCO)
> and that would be better decided on a patch-by-patch basis
> rather than a blanket statement.

IANAL either, but we have been striving to keep output of

   $ git grep '\.signoff' Documentation

empty to keep Sign-off meaningful.

Adding more publicized ways to add SoB without thinking will make it harder to argue against one who tells the court "that log message ends with a SoB by person X but it is very plausible that it was done by inertia without person X really intending to certify what DCO says, and the SoB is meaningless".

> I don't add my SoB to patches (either my own or received) until
> I'm comfortable with it; and I'd rather err on the side of
> forgetting and being prodded to resubmit rather than putting
> an SoB on the wrong patch.