Re: [PATCH] am: add am.signoff add config variable

From: Eduardo Habkost <ehabkost@redhat.com>
Date: Dec 28, 2016, 17:50 UTC
Message-ID: <20161228175047.GE3441@thinpad.lan.raisama.net>
In-Reply-To: <CAGZ79kbRMYyaOmuqymx9dsLGdvX+iM9OMMQtQGS=uA+dO6_MVQ@mail.gmail.com>

On Wed, Dec 28, 2016 at 09:45:24AM -0800, Stefan Beller wrote:

Show 10 quoted lines

> On Wed, Dec 28, 2016 at 9:40 AM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> > git-am has options to enable --message-id and --3way by default,
> > but no option to enable --signoff by default. Add a "am.signoff"
> > config option.
> 
> I think this is a good idea (from a design standpoint and what the user needs).
> 
> Just like e97a5e765d (git-am: add am.threeWay config variable), we'd
> prefer if you'd
> also update Documentation/config.txt as well as a new test. :)

Sorry, I was using commit e97a5e765d as reference when adding the new option, but I was looking at "git log -p builtin/am.c" and didn't see the rest of commit. :)

I will send a new version with the appropriate documentation and test code.

-- 
Eduardo