git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] am: add am.signoff add config variable

From
EHEduardo Habkost <ehabkost@redhat.com>
Date
Dec 29, 2016, 22:16 UTC
Message-ID
<20161229221605.GJ3441@thinpad.lan.raisama.net>
In-Reply-To
<xmqqtw9m5s5m.fsf@gitster.mtv.corp.google.com>
On Thu, Dec 29, 2016 at 01:42:13PM -0800, Junio C Hamano wrote:
Show 23 quoted lines
> Eric Wong <e@80x24.org> writes:
> 
> > Eduardo Habkost <ehabkost@redhat.com> wrote:
> >> git-am has options to enable --message-id and --3way by default,
> >> but no option to enable --signoff by default. Add a "am.signoff"
> >> config option.
> >
> > I'm not sure this is a good idea.  IANAL, but a sign-off
> > has some sort of legal meaning for this project (DCO)
> > and that would be better decided on a patch-by-patch basis
> > rather than a blanket statement.
> 
> IANAL either, but we have been striving to keep output of
> 
>    $ git grep '\.signoff' Documentation
> 
> empty to keep Sign-off meaningful. 
> 
> Adding more publicized ways to add SoB without thinking will make it
> harder to argue against one who tells the court "that log message
> ends with a SoB by person X but it is very plausible that it was
> done by inertia without person X really intending to certify what
> DCO says, and the SoB is meaningless".

This sounds completely reasonable to me. I now see that the config option was already proposed in 2011 and the same arguments were discussed. Sorry for the noise.

Show 6 quoted lines
> 
> > I don't add my SoB to patches (either my own or received) until
> > I'm comfortable with it; and I'd rather err on the side of
> > forgetting and being prodded to resubmit rather than putting
> > an SoB on the wrong patch.
> 
-- 
Eduardo
Previous: Junio C HamanoNext: Stefan Beller
Message 8 of 11 in “am: add am.signoff add config variable”
  1. am: add am.signoff add config variableEduardo Habkost, Dec 28, 2016
  2. Stefan BellerDec 28, 2016
  3. Eduardo HabkostDec 28, 2016
  4. Eric WongDec 29, 2016
  5. Eduardo HabkostDec 29, 2016
  6. Jacob KellerDec 29, 2016
  7. Junio C HamanoDec 29, 2016
  8. Eduardo HabkostDec 29, 2016
  9. Stefan BellerDec 29, 2016
  10. Junio C HamanoDec 29, 2016
  11. Stefan BellerDec 29, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.