Re: [PATCH 03/20] cat-file: rename variables in ref-filter

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 9, 2018, 22:04 UTC
Message-ID: <xmqqtvvu3d0a.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <01020160db067bde-7f500636-b80e-4099-a84e-2613126c9aa1-000000@eu-west-1.amazonses.com>

Olga Telezhnaya <olyatelezhnaya@gmail.com> writes:

> Rename some variables for easier reading.
> They point not to values, but to arrays.

Once the code is written and people start to build on top, a change like this is not worth the code churn, especially because there are two equally valid schools of naming convention.

 - When you have an array, each of whose 20 slots holds a single
   dosh, I would prefer to call the array dosh[20], not doshes[20],
   so that I can refer to the seventh dosh as "dosh[7]".

 - If you more often refer to the array as a whole (than you refer
   to individual elements) and want to stress the fact that the
   array holds multiple elements in it, I can understand that you
   may be tempted to call the whole array "doshes[]".

So please drop this and other "rename variables" patches from the series.