git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 11/20] cat-file: get rid of duplicate checking

From
Olga Telezhnaya <olyatelezhnaya@gmail.com>
Date
Jan 9, 2018, 13:05 UTC
Message-ID
<01020160db067b11-6e867688-40cb-4467-954d-847076ff6157-000000@eu-west-1.amazonses.com>
In-Reply-To
<01020160db0679c9-799a0bc4-b6d1-43e2-ad3b-80be4e4c55e9-000000@eu-west-1.amazonses.com>

We could remove this because we have already checked that at verify_ref_format function in ref-filter.

Signed-off-by: Olga Telezhnaia <olyatelezhnaya@gmail.com>
Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored by: Jeff King <peff@peff.net>
---
 builtin/cat-file.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/builtin/cat-file.c b/builtin/cat-file.c
index dd43457c0ad7e..1f331559e55c7 100644
--- a/builtin/cat-file.c
+++ b/builtin/cat-file.c
@@ -197,8 +197,6 @@ static void expand_atom(struct strbuf *sb, const char *atom, int len,
 		strbuf_addstr(sb, data->rest);
 	else if (is_atom("deltabase", atom, len))
 		strbuf_addstr(sb, oid_to_hex(&data->delta_base_oid));
-	else
-		die("unknown format element: %.*s", len, atom);
 }
 
 static size_t expand_format(struct strbuf *sb, const char *start, void *vdata)

--
https://github.com/git/git/pull/450
Previous: Olga TelezhnayaNext: Olga Telezhnaya
Message 2 of 24 in “cat-file: split expand_atom into 2 functions”
  1. 01/20 cat-file: split expand_atom into 2 functionsOlga Telezhnaya, Jan 9, 2018
  2. 11/20 cat-file: get rid of duplicate checkingOlga Telezhnaya, Jan 9, 2018
  3. 10/20 cat-file: simplify expand_atom functionOlga Telezhnaya, Jan 9, 2018
  4. 09/20 cat-file: get rid of goto in ref-filterOlga Telezhnaya, Jan 9, 2018
  5. 15/20 cat-file: start reusing populate_valueOlga Telezhnaya, Jan 9, 2018
  6. 19/20 cat-file: move skip_object_info into ref-filterOlga Telezhnaya, Jan 9, 2018
  7. 14/20 cat-file: make populate_value globalOlga Telezhnaya, Jan 9, 2018
  8. 20/20 cat-file: make cat_file_info variable independentOlga Telezhnaya, Jan 9, 2018
  9. 04/20 cat-file: make valid_atoms as a function parameterOlga Telezhnaya, Jan 9, 2018
  10. Junio C HamanoJan 9, 2018
  11. 07/20 cat-file: reuse parse_ref_filter_atomOlga Telezhnaya, Jan 9, 2018
  12. Junio C HamanoJan 9, 2018
  13. 12/20 cat-file: rename variable in ref-filterOlga Telezhnaya, Jan 9, 2018
  14. 06/20 cat-file: start migrating to ref-filterOlga Telezhnaya, Jan 9, 2018
  15. 02/20 cat-file: reuse struct ref_formatOlga Telezhnaya, Jan 9, 2018
  16. 18/20 cat-file: add split_on_whitespace flagOlga Telezhnaya, Jan 9, 2018
  17. 13/20 cat-file: start use ref_array_item structOlga Telezhnaya, Jan 9, 2018
  18. 17/20 cat-file: add is_cat flag in ref-filterOlga Telezhnaya, Jan 9, 2018
  19. 16/20 cat-file: get rid of expand_atom_into_fieldsOlga Telezhnaya, Jan 9, 2018
  20. 03/20 cat-file: rename variables in ref-filterOlga Telezhnaya, Jan 9, 2018
  21. Junio C HamanoJan 9, 2018
  22. Оля ТележнаяJan 10, 2018
  23. 08/20 cat-file: remove unused codeOlga Telezhnaya, Jan 9, 2018
  24. 05/20 cat-file: move struct expand_data into ref-filterOlga Telezhnaya, Jan 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.