Re: SKIP_DASHED_BUILT_INS does not install git-*-pack

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 20, 2020, 01:54 UTC
Message-ID: <xmqqtuupd5m2.fsf@gitster.c.googlers.com>
In-Reply-To: <CAGw6cBsEjOnh-ZqXCPfFha=NYEdy7JDddha=UzAau0Z1tBrWKg@mail.gmail.com>

Michael Forney <mforney@mforney.org> writes:

Show 14 quoted lines

> I saw that git 2.29.0 introduced a new make variable
> SKIP_DASHED_BUILT_INS. However, after testing it out I noticed that it
> skips installation of bin/git-receive-pack bin/git-upload-archive and
> bin/git-upload-pack as well.
>
> There is a comment that says these commands are special and expected
> to be in the bin/ directory in dashed form, so unless I'm missing
> something, I believe this is unintended.
>
> This seems to be the offending hunk:
> https://github.com/git/git/commit/94de88c986712e79c20813ba54e797c4ca83137b#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L2979-R2993
>
> Reverting that hunk restores git-receive-pack, git-upload-archive, and
> git-upload-pack (and only those).

Thanks for a report.  Dscho?