Re: SKIP_DASHED_BUILT_INS does not install git-*-pack

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 21, 2020, 14:27 UTC
Message-ID: <nycvar.QRO.7.76.6.2010211626430.56@tvgsbejvaqbjf.bet>
In-Reply-To: <CAGw6cBsEjOnh-ZqXCPfFha=NYEdy7JDddha=UzAau0Z1tBrWKg@mail.gmail.com>

Hi Michael,

On Mon, 19 Oct 2020, Michael Forney wrote:

Show 14 quoted lines

> I saw that git 2.29.0 introduced a new make variable
> SKIP_DASHED_BUILT_INS. However, after testing it out I noticed that it
> skips installation of bin/git-receive-pack bin/git-upload-archive and
> bin/git-upload-pack as well.
>
> There is a comment that says these commands are special and expected
> to be in the bin/ directory in dashed form, so unless I'm missing
> something, I believe this is unintended.
>
> This seems to be the offending hunk:
> https://github.com/git/git/commit/94de88c986712e79c20813ba54e797c4ca83137b#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L2979-R2993
>
> Reverting that hunk restores git-receive-pack, git-upload-archive, and
> git-upload-pack (and only those).

Indeed. I purposefully investigated without having a look at what you linked at, and came to the exact same conclusion.

As soon as the build passed, I will send this to the list: https://github.com/gitgitgadget/git/pull/768

Thanks, Dscho