Re: SKIP_DASHED_BUILT_INS does not install git-*-pack
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 21, 2020, 14:16 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2010211614300.56@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20201020025247.GF54484@nand.local>
Hi Taylor,
On Mon, 19 Oct 2020, Taylor Blau wrote:
Show 26 quoted lines
> diff --git a/Makefile b/Makefile
> index 95571ee3fc..1b2b085765 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2991,17 +2991,14 @@ endif
> cp "$$bindir/git$X" "$$bindir/$$p" || exit; }; \
> fi \
> done && \
> - for p in $(BUILT_INS); do \
> + for p in $(ALL_COMMANDS_TO_INSTALL); do \
> $(RM) "$$execdir/$$p" && \
> - if test -z "$(SKIP_DASHED_BUILT_INS)"; \
> - then \
> - test -n "$(INSTALL_SYMLINKS)" && \
> - ln -s "$$destdir_from_execdir_SQ/$(bindir_relative_SQ)/git$X" "$$execdir/$$p" || \
> - { test -z "$(NO_INSTALL_HARDLINKS)" && \
> - ln "$$execdir/git$X" "$$execdir/$$p" 2>/dev/null || \
> - ln -s "git$X" "$$execdir/$$p" 2>/dev/null || \
> - cp "$$execdir/git$X" "$$execdir/$$p" || exit; }; \
> - fi \
> + test -n "$(INSTALL_SYMLINKS)" && \
> + ln -s "$$destdir_from_execdir_SQ/$(bindir_relative_SQ)/git$X" "$$execdir/$$p" || \
> + { test -z "$(NO_INSTALL_HARDLINKS)" && \
> + ln "$$execdir/git$X" "$$execdir/$$p" 2>/dev/null || \
> + ln -s "git$X" "$$execdir/$$p" 2>/dev/null || \
> + cp "$$execdir/git$X" "$$execdir/$$p" || exit; }; \This code talks about `execdir`; I am fairly certain that we do not need anything specific in `libexec/git-core/`. However, for purposes of fetching/pushing, the mentioned executables should be present in the `bin/` directory in dashed form, no matter whether they are built-ins or not.
In a not-so-distant future, we might even be able to teach Git to call for the undashed form. But the problem there is that the Git doing the asking is on the client side, while the Git possibly missing the dashed forms is on the remote side.
Ciao, Dscho