Re: [PATCH v3 03/19] convert: add get_stream_filter_ca() variant

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 29, 2020, 23:51 UTC
Message-ID: <xmqqtuuc382h.fsf@gitster.c.googlers.com>
In-Reply-To: <c77b16f694cfe8076e66f604c0bbe053f58a2e9e.1603937110.git.matheus.bernardino@usp.br>

Matheus Tavares <matheus.bernardino@usp.br> writes:

Show 14 quoted lines

> From: Jeff Hostetler <jeffhost@microsoft.com>
>
> Like the previous patch, we will also need to call get_stream_filter()
> with a precomputed `struct conv_attrs`, when we add support for parallel
> checkout workers. So add the _ca() variant which takes the conversion
> attributes struct as a parameter.
>
> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
> [matheus.bernardino: move header comment to ca() variant and reword msg]
> Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br>
> ---
>  convert.c | 28 +++++++++++++++++-----------
>  convert.h |  2 ++
>  2 files changed, 19 insertions(+), 11 deletions(-)

Same idea as 02/19, which is sound.

It makes readers wonder why this one is separate, while convert_to_working_tree(), async_convert_to_working_tree(), and renormalize_buffer() were done in a single patch in a single step, though.