Re: [PATCH v4 04/19] convert: add conv_attrs classification
- From
Matheus Tavares Bernardino <matheus.bernardino@usp.br>
- Date
- Dec 5, 2020, 22:08 UTC
- Message-ID
- <CAHd-oW6yvPH24kTedX1LzBvZw3zMi4=QN6iXh5myHkC-bqKcZA@mail.gmail.com>
- In-Reply-To
- <CAP8UFD30JOhFxxSU=bVY9YfSHAjVJAKabLEv4x28JotOdj8xRA@mail.gmail.com>
On Sat, Dec 5, 2020 at 9:07 AM Christian Couder <christian.couder@gmail.com> wrote:
Show 13 quoted lines
> > On Wed, Nov 4, 2020 at 9:33 PM Matheus Tavares > <matheus.bernardino@usp.br> wrote: > > > > From: Jeff Hostetler <jeffhost@microsoft.com> > > > > Create `enum conv_attrs_classification` to express the different ways > > that attributes are handled for a blob during checkout. > > Micronit: the subject of the patch might want to be a bit more > explicit like "convert: add conv_attrs_classification enum". Otherwise > it could make one wonder if it is missing an underscore between > "conv_attrs" and "classification".
Makes sense, thanks!