Re: [PATCH v4 04/19] convert: add conv_attrs classification
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Dec 5, 2020, 12:07 UTC
- Message-ID
- <CAP8UFD30JOhFxxSU=bVY9YfSHAjVJAKabLEv4x28JotOdj8xRA@mail.gmail.com>
- In-Reply-To
- <aa1eb461f46d200f36b33c07ebc0a350829ab1f5.1604521275.git.matheus.bernardino@usp.br>
On Wed, Nov 4, 2020 at 9:33 PM Matheus Tavares <matheus.bernardino@usp.br> wrote:
Show 5 quoted lines
> > From: Jeff Hostetler <jeffhost@microsoft.com> > > Create `enum conv_attrs_classification` to express the different ways > that attributes are handled for a blob during checkout.
Micronit: the subject of the patch might want to be a bit more explicit like "convert: add conv_attrs_classification enum". Otherwise it could make one wonder if it is missing an underscore between "conv_attrs" and "classification".
Show 7 quoted lines
> This will be used in a later commit when deciding whether to add a file > to the parallel or delayed queue during checkout. For now, we can also > use it in get_stream_filter_ca() to simplify the function (as the > classifying logic is the same). > > Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com> > [matheus.bernardino: use classification in get_stream_filter_ca()]
Maybe "Co-authored-by: Matheus Tavares <matheus.bernardino@usp.br>" instead?
> Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br>