git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6] Push negotiation

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 30, 2021, 05:42 UTC
Message-ID
<xmqqtunocoqf.fsf@gitster.g>
In-Reply-To
<cover.1617929278.git.jonathantanmy@google.com>
Jonathan Tan <jonathantanmy@google.com> writes:
Show 20 quoted lines
> Here are patches for push negotiation. The basic idea is that we can
> reuse part of the fetch protocol (and code) to find out what is in
> common between the client and server, and then use that information to
> further narrow the objects sent in the packfile during a push.
>
> Patch 1 is a bug fix that probably should be merged even if the rest
> aren't. Patches 2-4 are refactorings in preparation for the future
> patches. Patches 5-6 contain the actual logic and documentation.
>
> I have written more about it in my prior work [1], although the commit
> messages and documentation in patches 5-6 should be enough to explain
> what's going on. (If they're not, feel free to make review comments.)
>
> The main change from [1] is that the client-side code that used to be in
> builtin/fetch-pack.c is now in builtin/fetch.c, because I realized that
> builtin/fetch-pack.c does not support HTTP. Other than that, all the
> "what hasn't been done yet" items have been done except for statistics
> in the commit message.
>
> [1] https://lore.kernel.org/git/20210218012100.928957-1-jonathantanmy@google.com/
So... anybody else wants to review this and give it a-OK?
Show 23 quoted lines
> Jonathan Tan (6):
>   fetch-pack: buffer object-format with other args
>   fetch-pack: refactor process_acks()
>   fetch-pack: refactor add_haves()
>   fetch-pack: refactor command and capability write
>   fetch: teach independent negotiation (no packfile)
>   send-pack: support push negotiation
>
>  Documentation/config/push.txt           |   7 +
>  Documentation/technical/protocol-v2.txt |   8 +
>  builtin/fetch.c                         |  27 ++-
>  fetch-pack.c                            | 224 +++++++++++++++---------
>  fetch-pack.h                            |  11 ++
>  object.h                                |   2 +-
>  send-pack.c                             |  61 ++++++-
>  t/t5516-fetch-push.sh                   |  35 ++++
>  t/t5701-git-serve.sh                    |   2 +-
>  t/t5702-protocol-v2.sh                  |  89 ++++++++++
>  transport-helper.c                      |  10 ++
>  transport.c                             |  30 +++-
>  transport.h                             |   6 +
>  upload-pack.c                           |  18 +-
>  14 files changed, 430 insertions(+), 100 deletions(-)
Previous: Derrick StoleeNext: Derrick Stolee
Message 22 of 33 in “Push negotiation”
  1. 0/6 Push negotiationJonathan Tan, Apr 9, 2021
  2. 1/6 fetch-pack: buffer object-format with other argsJonathan Tan, Apr 9, 2021
  3. Junio C HamanoApr 9, 2021
  4. Jonathan TanApr 9, 2021
  5. 2/6 fetch-pack: refactor process_acks()Jonathan Tan, Apr 9, 2021
  6. Junio C HamanoApr 9, 2021
  7. Derrick StoleeMay 3, 2021
  8. 3/6 fetch-pack: refactor add_haves()Jonathan Tan, Apr 9, 2021
  9. Junio C HamanoApr 9, 2021
  10. 4/6 fetch-pack: refactor command and capability writeJonathan Tan, Apr 9, 2021
  11. Junio C HamanoApr 9, 2021
  12. 5/6 fetch: teach independent negotiation (no packfile)Jonathan Tan, Apr 9, 2021
  13. Junio C HamanoApr 9, 2021
  14. Jonathan TanApr 9, 2021
  15. Derrick StoleeMay 3, 2021
  16. Derrick StoleeMay 3, 2021
  17. Jonathan TanMay 3, 2021
  18. 6/6 send-pack: support push negotiationJonathan Tan, Apr 9, 2021
  19. Derrick StoleeMay 3, 2021
  20. Jonathan TanMay 3, 2021
  21. Derrick StoleeMay 4, 2021
  22. Junio C HamanoApr 30, 2021
  23. Derrick StoleeApr 30, 2021
  24. 0/5 Push negotiationJonathan Tan, May 4, 2021
  25. 1/5 fetch-pack: refactor process_acks()Jonathan Tan, May 4, 2021
  26. 2/5 fetch-pack: refactor add_haves()Jonathan Tan, May 4, 2021
  27. 3/5 fetch-pack: refactor command and capability writeJonathan Tan, May 4, 2021
  28. 4/5 fetch: teach independent negotiation (no packfile)Jonathan Tan, May 4, 2021
  29. Junio C HamanoMay 5, 2021
  30. Derrick StoleeMay 5, 2021
  31. Junio C HamanoMay 6, 2021
  32. Derrick StoleeMay 5, 2021
  33. 5/5 send-pack: support push negotiationJonathan Tan, May 4, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.