Re: [PATCH 1/3] t5730: introduce fetch command helper
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 9, 2021, 21:43 UTC
- Message-ID
- <xmqqtujye1l5.fsf@gitster.g>
- In-Reply-To
- <YRGEwFauT5QjMSNO@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 12 quoted lines
> Here the entirety of the input to "test-tool pkt-line pack" is the > entirety of the output from write_fetch_command, which would suggest > either > > a. making write_fetch_command pipe its output to "test-tool pkt-line > pack", or > > b. using a pipe instead of a command substitution, like > "write_fetch_command ... | test-tool pkt-line pack >in" > > (although as mentioned above, I think it's simpler to inline the > write_fetch_command and even the write_command as well).
Yeah, write_command was not saving all that much to begin with. I was hoping that there were a lot more commonality that we can save some typing.