Re: [PATCH v3] upload-pack.c: treat want-ref relative to namespace

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 4, 2021, 22:17 UTC
Message-ID: <CAPig+cTVOC_MndYTQqCY5PpCtXWSRm17FULf7eW26giVoCN-6Q@mail.gmail.com>
In-Reply-To: <CDB2GX6ICZMC.1FDRFIKZU9GU6@schmidt>

On Wed, Aug 4, 2021 at 6:04 PM Kim Altintop <kim@eagain.st> wrote:

Show 12 quoted lines

> On Wed Aug 4, 2021 at 11:15 PM CEST, Junio C Hamano wrote:
> > Kim Altintop <kim@eagain.st> writes:
> > > +   env GIT_NAMESPACE=ns test-tool -C "$REPO" serve-v2 --stateless-rpc >out <in &&
> >
> > I am not sure why we want "env" in front (it does not hurt, but it
> > should be unnecessary, as test-tool is a plain-vanilla binary
> > executable, not a shell function). Is this a workaround for a buggy
> > test linter or something?
>
> The linter did indeed ask me to write `GIT_NAMESPACE=ns && export GIT_NAMESPACE
> && test-tool ...` in v1 of the patch, but now it doesn't... nevermind, I must
> have held something the wrong way.

The linter will complain about unportable:

    export FOO=bar

and ask you to write it as:

    FOO=bar && export FOO

which is probably what you encountered.

It will also complain about

    FOO=bar some-command

which should be rewritten as:

    env FOO=bar some-command

if, and only if, `some-command` is a shell function. If not a shell function, then:

    FOO=bar some-command

is just fine.