Re: [PATCH v2 04/11] object-file API: have write_object_file() take "enum object_type"

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 4, 2022, 20:52 UTC
Message-ID: <xmqqtudel5hj.fsf@gitster.g>
In-Reply-To: <patch-v2-04.11-d259f901114-20220204T135005Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 13 quoted lines

> diff --git a/builtin/notes.c b/builtin/notes.c
> index 05d60483e82..d81acaeaf78 100644
> --- a/builtin/notes.c
> +++ b/builtin/notes.c
> @@ -199,9 +199,8 @@ static void prepare_note_data(const struct object_id *object, struct note_data *
>  
>  static void write_note_data(struct note_data *d, struct object_id *oid)
>  {
> -	if (write_object_file(d->buf.buf, d->buf.len, blob_type, oid)) {
> +	if (write_object_file(d->buf.buf, d->buf.len, OBJ_BLOB, oid)) {
>  		int status = die_message(_("unable to write note object"));
> -
>  		if (d->edit_path)

Unrelated change here. It would be OK if it were an improvement, but it is not X-<.

Everything else in this change looked sensible.